Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CARTO: Don't render demo in docusaurus build #8301

Merged
merged 2 commits into from
Nov 21, 2023
Merged

CARTO: Don't render demo in docusaurus build #8301

merged 2 commits into from
Nov 21, 2023

Conversation

felixpalmer
Copy link
Collaborator

For #8193

Background

Use of fetch breaks the website build

Change List

  • Only render demo in browser

@felixpalmer felixpalmer mentioned this pull request Nov 21, 2023
Closed
23 tasks
donmccurdy
donmccurdy approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on Docusaurus documentation for <BrowserOnly/>.

I'm missing a few steps in my local repo setup to be able to reproduce the original issue, but I'll follow up about that offline.

@felixpalmer felixpalmer merged commit a0fc7db into master Nov 21, 2023
2 checks passed
@felixpalmer felixpalmer deleted the felix/carto-example-browseronly branch November 21, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

@alasarr alasarr Awaiting requested review from alasarr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixpalmer @donmccurdy