Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to use luma 4.0.1 version #849

Merged
merged 1 commit into from
Aug 15, 2017
Merged

Conversation

1chandu
Copy link
Contributor

@1chandu 1chandu commented Aug 15, 2017

No description provided.

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought: it should be enough to bump the main package.json for deck.gl, the peerDependency should be combined with the apps dependency and result in the newer version.

@1chandu
Copy link
Contributor Author

1chandu commented Aug 15, 2017

I thought the updates to package.json files within examples needed to run the examples as standalone(copy example folder to a different place and run without deck.gl source).

@1chandu 1chandu merged commit 8047bc2 into master Aug 15, 2017
@1chandu 1chandu deleted the bumpLumaVersion branch August 15, 2017 18:44
@ibgreen
Copy link
Collaborator

ibgreen commented Aug 15, 2017

OK I see. It would be more appropriate to update the packages to use deck.gl 4.1.1 but we can't do that until we publish.

The reason that it is more appropriate is that for most users it is a technicality that luma.gl is a dependency of deck.gl and they should not have to worry about manually tracking its versions in addition to deck.gl versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants