Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dev dependencies #8653

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Clean up dev dependencies #8653

merged 1 commit into from
Mar 15, 2024

Conversation

Pessimistress
Copy link
Collaborator

See inline comments

Change List

  • Remove unused dev dependencies from root package.json

@@ -47,25 +47,16 @@
"jsdom": false
},
"devDependencies": {
"@arcgis/core": "^4.21.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modules/arcgis specific dependency, moved to submodule

@@ -47,25 +47,16 @@
"jsdom": false
},
"devDependencies": {
"@arcgis/core": "^4.21.0",
"@babel/register": "^7.13.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babel no longer used

package.json Outdated
"@loaders.gl/csv": "^4.2.0-alpha.5",
"@loaders.gl/polyfills": "^4.2.0-alpha.5",
"@luma.gl/test-utils": "^9.0.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already a dependency of modules/test-utils

"jsdom": "^20.0.0",
"ocular-dev-tools": "2.0.0-alpha.29",
"pre-commit": "^1.2.2",
"pre-push": "^0.1.1",
"puppeteer": "^22.4.0",
"react": "^18.2.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modules/react specific dependency, moved to submodule

"@luma.gl/webgpu": "^9.0.0",
"@math.gl/proj4": "^4.0.0",
"@probe.gl/bench": "^4.0.9",
"@probe.gl/test-utils": "^4.0.9",
"@types/react": "^18.2.0",
"abortcontroller-polyfill": "^1.5.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used

@coveralls
Copy link

coveralls commented Mar 14, 2024

Coverage Status

coverage: 86.408%. remained the same
when pulling 29e1d47 on x/dev-deps
into 6f75ec5 on master.

@Pessimistress Pessimistress merged commit 22d7c0e into master Mar 15, 2024
4 checks passed
@Pessimistress Pessimistress deleted the x/dev-deps branch March 15, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants