Clean up dev dependencies #8653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
commented
Mar 14, 2024
| @@ -47,25 +47,16 @@ | |||
| "jsdom": false | |||
| }, | |||
| "devDependencies": { | |||
| "@arcgis/core": "^4.21.0", | |||
There was a problem hiding this comment.
modules/arcgis specific dependency, moved to submodule
| @@ -47,25 +47,16 @@ | |||
| "jsdom": false | |||
| }, | |||
| "devDependencies": { | |||
| "@arcgis/core": "^4.21.0", | |||
| "@babel/register": "^7.13.0", | |||
There was a problem hiding this comment.
Babel no longer used
package.json
Outdated
| "@loaders.gl/csv": "^4.2.0-alpha.5", | ||
| "@loaders.gl/polyfills": "^4.2.0-alpha.5", | ||
| "@luma.gl/test-utils": "^9.0.0", |
There was a problem hiding this comment.
Already a dependency of modules/test-utils
| "jsdom": "^20.0.0", | ||
| "ocular-dev-tools": "2.0.0-alpha.29", | ||
| "pre-commit": "^1.2.2", | ||
| "pre-push": "^0.1.1", | ||
| "puppeteer": "^22.4.0", | ||
| "react": "^18.2.0", |
There was a problem hiding this comment.
modules/react specific dependency, moved to submodule
| "@luma.gl/webgpu": "^9.0.0", | ||
| "@math.gl/proj4": "^4.0.0", | ||
| "@probe.gl/bench": "^4.0.9", | ||
| "@probe.gl/test-utils": "^4.0.9", | ||
| "@types/react": "^18.2.0", | ||
| "abortcontroller-polyfill": "^1.5.0", |
felixpalmer
approved these changes
Mar 15, 2024
chrisgervang
approved these changes
Mar 15, 2024
Pessimistress
force-pushed
the
x/dev-deps
branch
from
6356627
to
29e1d47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See inline comments
Change List