Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react) component default size #8766

Merged
merged 1 commit into from
Apr 7, 2024
Merged

fix(react) component default size #8766

merged 1 commit into from
Apr 7, 2024

Conversation

Pessimistress
Copy link
Collaborator

FunctionComponent.defaultProps has been deprecated by React. DeckGL.defaultProps was removed in #8763 without providing fallbacks causing the canvas to be 0x0.

Change List

  • Use React's recommended approach to supply default width and height

@Pessimistress Pessimistress changed the title Fix React component default size fix(react) component default size Apr 7, 2024
@coveralls
Copy link

Coverage Status

coverage: 89.987%. remained the same
when pulling aad224a on x/website-fix
into 8ec5555 on master.

@Pessimistress Pessimistress merged commit 423fc95 into master Apr 7, 2024
4 checks passed
@Pessimistress Pessimistress deleted the x/website-fix branch April 7, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants