-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Clean up license text #2729
Conversation
f63c0b2
to
d840dc7
Compare
I'd like to move towards using SPDX shorthand instead in our files:
Adding the copyright to each file seems unnecessarily adding future work since they can change overtime, even with the year removed. MIT doesn't have a standard file header, however I'd lean towards adding all past and present (adding Uber's) if we're going to do it. |
|
||
This software includes parts of PhiloGL (https://github.com/philogb/philogl) | ||
under MIT license. PhiloGL parts Copyright © 2013 Sencha Labs. | ||
loaders.gl is licensed under the MIT license | ||
|
||
This software includes adaptations of postprocessing code from THREE.js (https://github.com/mrdoob/three.js/) under MIT license. Additional attribution given in specific source files. THREE.js parts Copyright © 2010-2018 three.js authors. | ||
Copyright (c) vis.gl contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting suggested by the Linux foundation:
MIT License
Copyright (c) vis.gl contributors
Copyright (c) 2015 Uber Technologies, Inc.
Permission is hereby granted...
The loaders.gl is licensed under the MIT license
phrasing is probably fine though since it's specifying among multiple licenses.
I don't like a massive header in each file, like the full MIT text. But since people do tend to copy individual files, I think it is nice to have a brief header in each file. I feel that:
With the year removed I don't see them changing unless we move to another foundation.
That looks a bit too technical to me to copy into every file. I assume this is for some tooling perhaps useful to have in root license files?
Did Uber transfer copyright to OpenJS foundation or did it retain it? The guidance I have seen so far is that we don't retain it, at least not in every file. |
I'm onboard with a brief header that includes the SPDX id. Its designed to be human and machine readable, and can be particularly useful in loaders since we combine multiple licenses in the same file - As I interpret it, Uber hasn't undone its past copyright.. it just doesn't claim it going forward since the LF transfer. Either way, it's good faith to present it in our root license below ours as other projects do (See Electron in a similar situation). There are no header requirements for every file, so it's up to the project to decide - its fine to keep the copyrights "current" in every file if that's what we decide to do, I just was expressing a personal leaning. How about this?
|
One reason I thought so was that I saw other projects using
So we'll have Also many files have been created post Uber transfer so adding that copyright to all files would also be incorrect. |
What does This all gets technical pretty fast. I think a proposal doc for all the repos is better than debating it in PR comments for one of them. |
Re: copyright, let's get clarity from the foundation. Robin told me the LF project, which is The A proposal sounds good to me too. All of this is something that'll help us graduate out of "incubator" status in OpenJS... that's my goal [see tasks]. |
No description provided.