Convert GetImageParameters to WMSGetMapParameters #2799
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WMSLayer
is broken in v9 deck: https://felixpalmer.github.io/deck.gl/examples/wms-layer due to theImageSource.getImage
function expecting parameters of the typeGetImageParameters
, while theWMSService.getImage
function expectsWMSGetMapParameters
. These differ only in the specification of the bounds, with the former usingboundingBox
and the latterbbox
.There are different ways this could be resolved but I'm assuming that the intended design is to have a unified
getImage
API and thus here the conversion is being done inWMSService.getImage