Convert GetImageParameters to WMSGetMapParameters #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
ibgreen
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Thanks for catching this. I think the confusion right now is due to the GetImage parameters are very closely modeled after WMS GetMap parameters with just this one exception.
But ultimately GetImage and GeMap parameters should probably be considered different types with a clear mapping function for all fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WMSLayeris broken in v9 deck: https://felixpalmer.github.io/deck.gl/examples/wms-layer due to theImageSource.getImagefunction expecting parameters of the typeGetImageParameters, while theWMSService.getImagefunction expectsWMSGetMapParameters. These differ only in the specification of the bounds, with the former usingboundingBoxand the latterbbox.There are different ways this could be resolved but I'm assuming that the intended design is to have a unified
getImageAPI and thus here the conversion is being done inWMSService.getImage