shadertools: specularColor tests (#2172)

visgl · Aug 9, 2024 · 8d64745 · 8d64745
1 parent a88537e
commit 8d64745
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/modules/shadertools/test/modules/lighting/gouraud-material.spec.ts b/modules/shadertools/test/modules/lighting/gouraud-material.spec.ts
@@ -26,7 +26,7 @@ test('shadertools#gouraudMaterial', t => {
   t.is(uniforms.ambient, 0, 'ambient');
   t.is(uniforms.diffuse, 0, 'diffuse');
   t.is(uniforms.shininess, 0, 'shininess');
-  t.deepEqual(uniforms.specularColor, [255, 0, 0], 'specularColor');
+  t.deepEqual(uniforms.specularColor, [1, 0, 0], 'specularColor');
 
   // uniforms = gouraudMaterial.getUniforms({
   //   material: null
@@ -39,11 +39,7 @@ test('shadertools#gouraudMaterial', t => {
   t.equal(uniforms.ambient, 0.35, 'ambient');
   t.equal(uniforms.diffuse, 0.6, 'diffuse');
   t.equal(uniforms.shininess, 32, 'shininess');
-  // t.deepEqual(
-  //   uniforms.specularColor,
-  //   [30 / 255, 30 / 255, 30 / 255],
-  //   'specularColor'
-  // );
+  t.deepEqual(uniforms.specularColor, [0.15, 0.15, 0.15], 'specularColor');
 
   t.end();
 });
diff --git a/modules/shadertools/test/modules/lighting/phong-material.spec.ts b/modules/shadertools/test/modules/lighting/phong-material.spec.ts
@@ -23,7 +23,7 @@ test('shadertools#phongMaterial', t => {
   t.is(uniforms.ambient, 0, 'ambient');
   t.is(uniforms.diffuse, 0, 'diffuse');
   t.is(uniforms.shininess, 0, 'shininess');
-  t.deepEqual(uniforms.specularColor, [255, 0, 0], 'specularColor');
+  t.deepEqual(uniforms.specularColor, [1, 0, 0], 'specularColor');
 
   // uniforms = phongMaterial.getUniforms({
   //   material: null
@@ -35,11 +35,7 @@ test('shadertools#phongMaterial', t => {
   t.equal(uniforms.ambient, 0.35, 'ambient');
   t.equal(uniforms.diffuse, 0.6, 'diffuse');
   t.equal(uniforms.shininess, 32, 'shininess');
-  // t.deepEqual(
-  //   uniforms.specularColor,
-  //   [30 / 255, 30 / 255, 30 / 255],
-  //   'specularColor'
-  // );
+  t.deepEqual(uniforms.specularColor, [0.15, 0.15, 0.15], 'specularColor');
 
   t.end();
 });