chore(core): Protect OffscreenCanvas reference in Node (#2266)

visgl · Sep 20, 2024 · bd65557 · bd65557
1 parent 1e63cd7
commit bd65557
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/modules/core/src/adapter/canvas-context.ts b/modules/core/src/adapter/canvas-context.ts
@@ -120,7 +120,7 @@ export abstract class CanvasContext {
       this.id = props.id || this.canvas.id;
       this.type = 'html-canvas';
       this.htmlCanvas = this.canvas;
-    } else if (this.canvas instanceof OffscreenCanvas) {
+    } else if (typeof OffscreenCanvas !== 'undefined' && this.canvas instanceof OffscreenCanvas) {
       this.id = props.id || 'offscreen-canvas';
       this.type = 'offscreen-canvas';
       this.offscreenCanvas = this.canvas;
@@ -459,10 +459,14 @@ function getContainer(container: HTMLElement | string | null): HTMLElement {
 /** Get a Canvas element from DOM id */
 function getCanvasFromDOM(canvasId: string): HTMLCanvasElement {
   const canvas = document.getElementById(canvasId);
-  if (!(canvas instanceof HTMLCanvasElement)) {
+  if (
+    typeof canvas !== 'undefined' &&
+    typeof HTMLCanvasElement !== 'undefined' &&
+    !(canvas instanceof HTMLCanvasElement)
+  ) {
     throw new Error('Object is not a canvas element');
   }
-  return canvas;
+  return canvas as HTMLCanvasElement;
 }
 
 /** Create a new canvas */