Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add UniformValue type for .setUniforms() etc #1792

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Aug 23, 2023

For #

Background

  • In v9, textures, samplers and uniform buffers are not considered uniforms and should be set with setBindings()
  • This causes IconLayer etc to fail.
  • With this change, setUniform({texture}) will generate a type error

Change List

  • Adding a UniformValue type to the setUniforms style APIs will guide applications to do the necessary changes.

@ibgreen ibgreen merged commit a9ae2e8 into master Aug 23, 2023
1 check passed
@ibgreen ibgreen deleted the ib/uniform-types branch August 23, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant