add(core) enforceWebGL2 #2067
Merged
add(core) enforceWebGL2 #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Gervang <chris@gervang.com>
|
What's the use case here? I think the latest versions of all supported base map libraries create WebGL2 by default. |
|
This can be used when an application isn't ready to upgrade from Mapbox v1 but still needs to do interleaved rendering. We're trying to upgrade Hubble and Kepler to v9 but are blocked since MapLibre has an unresolved rendering issue. |
ibgreen
approved these changes
Apr 5, 2024
ibgreen
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
This looks good, and since it unblocks the hubble.gl v9 upgrade I am strongly in favor of landing it.
- I made a push on the docs.
- Possible we add one test case?
- I called out that there may be an issue with some WebGL1 extensions not being available under WebGL2, potentially causing mapbox to not be able to use certain blend modes etc. It is not very hard to emulate these extensions, if we see any issues we could scan their code and see which extensions they are using.
|
Thanks! Yes, I'll add a test |
Signed-off-by: Chris Gervang <chris@gervang.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Use enforceWebGL2 when a library is creating its own WebGL1 context privately, in order to create a WebGL2 context that is compatible with luma.gl.
Change List