Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP shadertools: PBRMaterial UBO #2207

Merged
merged 4 commits into from
Aug 22, 2024
Merged

WIP shadertools: PBRMaterial UBO #2207

merged 4 commits into from
Aug 22, 2024

Conversation

felixpalmer
Copy link
Collaborator

@felixpalmer felixpalmer commented Aug 22, 2024 •
edited
Loading

Cherrypick of #2173

@ibgreen Current output, have you seen something like this before?:

Screen.Recording.2024-08-22.at.16.40.26.mov

@ibgreen
Copy link
Collaborator

ibgreen commented Aug 22, 2024

Cherrypick of #2173

@ibgreen Current output, have you seen something like this before?:

When rendering looks off, my first instinct is always to double check the normals

@ibgreen ibgreen merged commit fb55282 into master Aug 22, 2024
2 checks passed
@ibgreen ibgreen deleted the felix/pbr-ubo branch August 22, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixpalmer @ibgreen