chore: use @vis.gl/dev-tools #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
force-pushed
the
x/dev-tools
branch
from
2cfbbcf
to
f3fbfdf
Compare
ibgreen
approved these changes
Sep 1, 2024
|
|
||
| lint: { | ||
| paths: ['modules', 'docs', 'test'], // 'examples'], module resolution errors | ||
| paths: ['modules', 'test'], // 'docs', 'examples'], module resolution errors |
There was a problem hiding this comment.
I thought we had markdown linter?
There was a problem hiding this comment.
We do, but it was not used as .md was not listed in extensions. We can enable it in another PR it will likely result in a bunch of prettier changes.
There was a problem hiding this comment.
Sounds good. We probably need to add mdx as well
| "test-fast": "ocular-test fast", | ||
| "test-browser": "ocular-test browser", | ||
| "test-browser-headless": "ocular-test browser-headless | tap-spec", | ||
| "test-fast": "ocular-lint && ocular-test node", |
There was a problem hiding this comment.
Why keep this one? Not really useful at this stage, and with latest Puppeteer / Chromium browser tests are blazing fast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change List