Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use @vis.gl/dev-tools #2229

Merged
merged 6 commits into from
Sep 2, 2024
Merged

chore: use @vis.gl/dev-tools #2229

merged 6 commits into from
Sep 2, 2024

Conversation

Pessimistress
Copy link
Collaborator

Change List

  • Update to the latest tooling
  • Slight adjustments to lint rules, mostly removed the ones that are already defined in the base config

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!


lint: {
paths: ['modules', 'docs', 'test'], // 'examples'], module resolution errors
paths: ['modules', 'test'], // 'docs', 'examples'], module resolution errors
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we had markdown linter?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do, but it was not used as .md was not listed in extensions. We can enable it in another PR it will likely result in a bunch of prettier changes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. We probably need to add mdx as well

"test-fast": "ocular-test fast",
"test-browser": "ocular-test browser",
"test-browser-headless": "ocular-test browser-headless | tap-spec",
"test-fast": "ocular-lint && ocular-test node",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why keep this one? Not really useful at this stage, and with latest Puppeteer / Chromium browser tests are blazing fast.

@ibgreen ibgreen merged commit 7f99191 into master Sep 2, 2024
2 checks passed
@ibgreen ibgreen deleted the x/dev-tools branch September 2, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants