Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Consolidate texture implementations, move setters to AsyncTexture (v9.2) #2247

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Sep 6, 2024

For #

Background

  • Opening against 9.2-dev branch.
  • Continued Texture cleanup, targeting one of the hardest to maintain areas of luma.gl
  • Keep Texture minimally focused on exposing GPU capabilities, move convenience methods to AsyncTexture

Change List

  • Remove duplicated code between WebGL and WebGPU, simplify texture implementations, move sharable, non-platform-specific functions to AsyncTexture,

@ibgreen ibgreen changed the title chore: Consolidate texture implementations, move setters to AsyncTexture chore: Consolidate texture implementations, move setters to AsyncTexture (for 9.2) Sep 6, 2024
@ibgreen ibgreen changed the title chore: Consolidate texture implementations, move setters to AsyncTexture (for 9.2) chore: Consolidate texture implementations, move setters to AsyncTexture (v9.2) Sep 6, 2024
@ibgreen ibgreen merged commit ed160f6 into 9.2-dev Sep 7, 2024
2 checks passed
@ibgreen ibgreen deleted the ib/cleanup-textures branch September 7, 2024 01:13
ibgreen added a commit that referenced this pull request Sep 18, 2024
ibgreen added a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant