Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webgl: Canvas resizing minimal back-compatibility fix #2277

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

felixpalmer
Copy link
Collaborator

Background

Follow-up to #2237 which breaks canvas handling in deck.

@ibgreen I'm going to try and integrate this into deck to see if we can update luma9.1 there and move forward. I don't think it is worth trying to update deck to the new APIs in luma now, as there is still a lot of cleanup needed on the luma side (many TODOs & deprecated in the canvas-context.ts & webgl-canvas-context.ts)

Change List

  • Re-instate old behavior where WebGLCanvasContext.resize() calls _setDevicePixelRatio()

@felixpalmer felixpalmer merged commit 73c3939 into 9.1-release Oct 11, 2024
2 checks passed
@felixpalmer felixpalmer deleted the felix/fix-canvas-resize branch October 11, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant