fix(advanced-marker): remove content element in cleanup (#351)

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
visgl · May 9, 2024 · 128df87 · 128df87
1 parent bc10a6f
commit 128df87
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/components/advanced-marker.tsx b/src/components/advanced-marker.tsx
@@ -107,15 +107,17 @@ function useAdvancedMarker(props: AdvancedMarkerProps) {
     setMarker(newMarker);
 
     // create the container for marker content if there are children
+    let contentElement: HTMLDivElement | null = null;
     if (numChildren > 0) {
-      const contentElement = document.createElement('div');
+      contentElement = document.createElement('div');
 
       newMarker.content = contentElement;
       setContentContainer(contentElement);
     }
 
     return () => {
       newMarker.map = null;
+      contentElement?.remove();
       setMarker(null);
       setContentContainer(null);
     };