fix(map): change event-type of projectionChanged event to MapEvent (#346

) Fixes #342. BREAKING CHANGE: The type passed to the `onProjectionChange` is changed from `MapCameraChangedEvent` to `MapEvent`, so there are no longer camera-props available for this event
visgl · May 6, 2024 · 83f9309 · 83f9309
1 parent aba43ac
commit 83f9309
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/docs/api-reference/components/map.md b/docs/api-reference/components/map.md
@@ -225,7 +225,6 @@ Based on the specific event, there is also additional information in the
 | `zoom_changed`                    | `onZoomChanged`                         | `MapCameraChangedEvent` |
 | `heading_changed`                 | `onHeadingChanged`                      | `MapCameraChangedEvent` |
 | `tilt_changed`                    | `onTiltChanged`                         | `MapCameraChangedEvent` |
-| `projection_changed`              | `onProjectionChanged`                   | `MapCameraChangedEvent` |
 | `click`                           | `onClick`                               | `MapMouseEvent`         |
 | `contextmenu`                     | `onContextmenu`                         | `MapMouseEvent`         |
 | `dblclick`                        | `onDblclick`                            | `MapMouseEvent`         |
@@ -236,6 +235,7 @@ Based on the specific event, there is also additional information in the
 | `dragend`                         | `onDragend`                             | `MapEvent`              |
 | `dragstart`                       | `onDragstart`                           | `MapEvent`              |
 | `idle`                            | `onIdle`                                | `MapEvent`              |
+| `projection_changed`              | `onProjectionChanged`                   | `MapEvent`              |
 | `isfractionalzoomenabled_changed` | `onIsFractionalZoomEnabledChanged`      | `MapEvent`              |
 | `mapcapabilities_changed`         | `onMapCapabilitiesChanged`              | `MapEvent`              |
 | `maptypeid_changed`               | `onMapTypeIdChanged`                    | `MapEvent`              |

diff --git a/src/components/map/use-map-events.ts b/src/components/map/use-map-events.ts
@@ -10,7 +10,6 @@ export type MapEventProps = Partial<{
   onHeadingChanged: (event: MapCameraChangedEvent) => void;
   onTiltChanged: (event: MapCameraChangedEvent) => void;
   onZoomChanged: (event: MapCameraChangedEvent) => void;
-  onProjectionChanged: (event: MapCameraChangedEvent) => void;
   onCameraChanged: (event: MapCameraChangedEvent) => void;
 
   // mouse / touch / pointer events
@@ -29,6 +28,7 @@ export type MapEventProps = Partial<{
   onIdle: (event: MapEvent) => void;
 
   // configuration events
+  onProjectionChanged: (event: MapEvent) => void;
   onIsFractionalZoomEnabledChanged: (event: MapEvent) => void;
   onMapCapabilitiesChanged: (event: MapEvent) => void;
   onMapTypeIdChanged: (event: MapEvent) => void;
@@ -179,7 +179,6 @@ const cameraEventTypes = [
   'bounds_changed',
   'center_changed',
   'heading_changed',
-  'projection_changed',
   'tilt_changed',
   'zoom_changed'
 ];