Conntrack support #213
Merged
Conntrack support #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I will have to investigate the failure on Travis. |
fcrisciani
force-pushed
the
conntrack2
branch
3 times, most recently
from
6dfa8d0 to
f570540
Compare
- Conntrack table FLUSH
- Conntrack table DELETE with filter
The filter is only for IP field
- Conntrack table GET
The flow information is not complete, but the method
returns a simplified structure with basic flow info
Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
|
The issue was the missing modules in the kernel, added them into Travis file. |
Added tests for: Table FLUSH Table GET Table DELETE with filter Filter match Use a simple UDP client to create flows into the conntrack for testing purpose Each test will run in a separate network namespace so can run in parallel Added kernel module dependencies into the travis file Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
|
This looks good. I'm thinking we may need a conntrack_unspecified.go with NotImplemented calls so that projects build on non-linux environments? |
Enable compilation in non linux environments Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
|
Sure, let me take care of that |
|
@vishvananda done, should be ready to go now |
This was referenced May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 2 commits are introducing the support for netfilter conntrack into the library.
This PR is a dependency for the fix of the bug: moby/moby#8795
The first commit adds the logic to support the GET/FLUSH/DELETE of conntrack through netlink
The second commit adds a test on top