Add LinkSetTxQLen #257
Merged
Add LinkSetTxQLen #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
travis failed, but it's not related to this patch. seems to be test flakiness of some sort |
|
it looks like a few of the tests are failing on the new trusty ci runners. I haven't had time to investigate yet. |
Closed
openshift-merge-robot
added a commit
to openshift/origin
that referenced
this pull request
Sep 18, 2017
Automatic merge from submit-queue (batch tested with PRs 15834, 16321, 16353, 15298, 15433) Drop pkg/util/ipcmd, port to vishvananda/netlink (mostly) This drops our wrapper around /sbin/ip and ports the remaining code to use the netlink library instead. Except for the one place we were using ipcmd in pod_linux because netlink doesn't yet have a `LinkSetTxQLen`. I've submitted a PR for that (vishvananda/netlink#257) but until then, I just changed the code to call `exec` directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library currently lets you set txqlen at link creation time but doesn't let you modify it afterward. OpenShift wants to be able to do this so that it can belatedly fix the txqlen of veths created by docker. (Right now it has to exec "ip link set".)