Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency between pushState and onpopstate #389

Closed
wants to merge 3 commits into from

Conversation

chenghaoc
Copy link

  1. Consistency between pushState and onpopstate, the user registered actions should be called after state changed.
  2. Check state path to avoid the problem which will occur when other lib also modify the history state object.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 87.05% when pulling eb25e04 on changbenny:consistency into aa60550 on visionmedia:master.

@matthewp
Copy link
Collaborator

I think this would fix #293. Do you have time to submit a test by any chance?

@matthewp
Copy link
Collaborator

Going to close for now, let me know if you have a code example or test you can add.

@matthewp matthewp closed this Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants