Implement remove edge from clustering #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 18, 2019 09:07
|
just tested this out locally at http://localhost:8080/examples/other/clusteringByZoom/ looks good! |
|
It's what I've been using on my fork to get around clustering issues 😄 |
|
ok, I logged this issue to research this new scroll-blocking warning we're getting now. #72 It's just a warning, so I think we can take this bug fix now and follow up on the warning later. |
micahstubbs
reviewed
Jul 18, 2019
| @@ -1478,12 +1509,14 @@ class ClusterEngine { | |||
| // TODO: check that it works for both edges clustered | |||
| // (This might be paranoia) | |||
| } else { | |||
| delete this._clusterEdges[edgeId] | |||
| this._restoreEdge(edge) | |||
There was a problem hiding this comment.
this is the meaningful part of the diff
micahstubbs
approved these changes
Jul 18, 2019
|
@Tyler-Maclachlan published to npm as |
This was referenced Jul 26, 2019
|
💌 Thanks @Tyler-Maclachlan for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #21