-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added mvn repository support #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is great! Thanks for the PR!
There's a few parts of dead code that can be removed (pointed out in the review comments), and I'd also love to have an entry in CHANGELOG.md
to let people know that the new version now has Maven support.
Can you also make the change to -help
output ("mvn" value for -l
) in README.md
Usage - section?
I'll do a bit of testing still, but this looks really good!
mvn.go
Outdated
"time" | ||
) | ||
|
||
type MvnResponse struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This struct can be removed, as pointed out by the linter.
mvn.go
Outdated
} `json:"time"` | ||
} | ||
|
||
type MvnResponseUnpublished struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This struct can be removed, as pointed out by the linter.
Glad to help; fixed al problems and changed CHANGELOG.md & README.md First GO project I ever worked on; never to old to learn. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! LGTM, merging!
Thanks again!
No description provided.