Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mvn repository support #22

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Conversation

rlschilperoort
Copy link
Contributor

No description provided.

Copy link
Member

@joohoi joohoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is great! Thanks for the PR!

There's a few parts of dead code that can be removed (pointed out in the review comments), and I'd also love to have an entry in CHANGELOG.md to let people know that the new version now has Maven support.

Can you also make the change to -help output ("mvn" value for -l) in README.md Usage - section?

I'll do a bit of testing still, but this looks really good!

mvn.go Outdated
"time"
)

type MvnResponse struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This struct can be removed, as pointed out by the linter.

mvn.go Outdated
} `json:"time"`
}

type MvnResponseUnpublished struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This struct can be removed, as pointed out by the linter.

@rlschilperoort
Copy link
Contributor Author

Glad to help; fixed al problems and changed CHANGELOG.md & README.md

First GO project I ever worked on; never to old to learn.

Copy link
Member

@joohoi joohoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! LGTM, merging!

Thanks again!

@joohoi joohoi merged commit cdd385a into visma-prodsec:main Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants