Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP (composer) support #4

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Add PHP (composer) support #4

merged 1 commit into from
Feb 12, 2021

Conversation

flavioheleno
Copy link
Contributor

@flavioheleno flavioheleno commented Feb 11, 2021

This PR adds support for PHP checking based on Composer dependency manager.

The dependencies are checked against Composer's official package repository Packagist.

Please note that the way composer handles dependencies is quite different from pip and npm, the developer can define[1]:

  1. Different source repositories for a package
  2. Different package repository without disabling Packagist
  3. Different package repository disabling Packagist

The current implementation does not check for those configuration changes.

There is also a very thorough blog post[2] that explains why PHP/Composer is not susceptive to this attack.

[1] https://getcomposer.org/doc/05-repositories.md
[2] https://blog.packagist.com/preventing-dependency-hijacking/

Copy link
Member

@joohoi joohoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks, merging it in!

@joohoi joohoi merged commit 2f01505 into visma-prodsec:main Feb 12, 2021
@flavioheleno flavioheleno deleted the feat/php branch February 12, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants