Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimension description #716

Merged
merged 11 commits into from
Sep 16, 2022
Merged

Dimension description #716

merged 11 commits into from
Sep 16, 2022

Conversation

ptbrowne
Copy link
Collaborator

  • feat: Add tooltip for dimension which have descriptions
  • feat: Use drop-shadow for arrow to be included in shadow
  • feat: Add dimension tooltip in data table

@vercel
Copy link

vercel bot commented Sep 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
visualization-tool ✅ Ready (Inspect) Visit Preview Sep 16, 2022 at 8:07AM (UTC)

Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But I think we are missing the table implementation 😅

app/docs/components.tsx Show resolved Hide resolved
@ptbrowne ptbrowne force-pushed the fix/tooltip-description branch from e6aff4c to 17dd441 Compare September 15, 2022 15:24
@ptbrowne
Copy link
Collaborator Author

Fixed the overflow issue and added the table implementation (along with a refactor to try to clean things up, and have better types).

@ptbrowne ptbrowne merged commit be6bf24 into main Sep 16, 2022
@ptbrowne ptbrowne deleted the fix/tooltip-description branch September 16, 2022 08:14
import * as React from "react";
import React from "react";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants