Updated consul config template and parameters to comply with latest version #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @garry-t |
The automated tests were successful. Judging by the changes, there should be no problems, however, can you test your changes to make sure they don't cause problems? |
I can say that I upgraded my staging and production cluster with these changes in the role, were no issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is only fixes I made to have cluster working during upgrade from 1.11.4. As I said in opened issue, role has other fixes which is in PR state and must be merged to current master branch. It is up to you copy them from PR to your role or no.
I didnt copy it to my consul role I cant say is it stable fix or no