-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add role 'pre-cheks' #369
Merged
Merged
Add role 'pre-cheks' #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of Changes: This commit introduces a new role, pre-checks, to our Ansible playbook for the PostgreSQL cluster project. The purpose of this role is to consolidate various preliminary checks scattered throughout the code into one cohesive role. This new role is designed to run before any cluster deployment begins. Why this Change is Necessary: The creation of the pre-checks role aims to improve the overall readability, maintainability, and failure handling of our playbook. By centralizing all preliminary checks, we can prevent scenarios where the playbook halts in the middle due to a failed check for a specific role. Instead, all checks are performed upfront, ensuring that actual deployment will only proceed if all checks pass. Key Points: The pre-checks role will be the first role executed during the playbook run. All existing preliminary checks from other roles will be migrated into this role. Future checks can be easily added to this role, simplifying the process for further updates or additions. Expected Outcome: With these changes, we anticipate smoother playbook executions with fewer disruptions. This should enhance the user experience by providing clear, upfront information about any issues that may affect the deployment of the cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
This PR introduces a new role '
pre-checks
', to our Ansible playbook for the PostgreSQL cluster project. The purpose of this role is to consolidate various preliminary checks scattered throughout the code into one cohesive role. This new role is designed to run before any cluster deployment begins.Why this Change is Necessary:
The creation of the pre-checks role aims to improve the overall readability, maintainability, and failure handling of our playbook. By centralizing all preliminary checks, we can prevent scenarios where the playbook halts in the middle due to a failed check for a specific role. Instead, all checks are performed upfront, ensuring that actual deployment will only proceed if all checks pass.
Key Points:
The pre-checks role will be the first role executed during the playbook run. All existing preliminary checks from other roles will be migrated into this role. Future checks can be easily added to this role, simplifying the process for further updates or additions.
Expected Outcome:
With these changes, we anticipate smoother playbook executions with fewer disruptions. This should enhance the user experience by providing clear, upfront information about any issues that may affect the deployment of the cluster.