Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection cancellation token is ignored #109

Closed
ForNeVeR opened this issue Sep 21, 2021 · 0 comments · Fixed by #110
Closed

Connection cancellation token is ignored #109

ForNeVeR opened this issue Sep 21, 2021 · 0 comments · Fixed by #110
Assignees
@ForNeVeR
Labels
kind:bug

Comments

@ForNeVeR
Copy link
Collaborator

We have a nice api XmppTcpConnection::ConnectAsync(CancellationToken), but the token is completely ignored there.

This breaks an ability to cancel the connection.
@ForNeVeR ForNeVeR self-assigned this Sep 21, 2021
ForNeVeR added a commit that referenced this issue Sep 21, 2021
@ForNeVeR
(#109) Build: add .NET 5 support, update language version
3cb2ddb 
Explicit .NET 5 build is required to support TcpClient connection
cancellation.
@ForNeVeR ForNeVeR mentioned this issue Sep 21, 2021
Merged
ForNeVeR added a commit that referenced this issue Sep 21, 2021
@ForNeVeR
(#109) XmppTcpConnection: cancellable TCP client connections
5aab2a9
ForNeVeR added a commit that referenced this issue Sep 21, 2021
@ForNeVeR
(#109) XmppTcpConnection: cancellable TCP client connections
138056d
ForNeVeR added a commit that referenced this issue Sep 21, 2021
@ForNeVeR
(#109) XmppTcpConnection: cancellable TCP client connections
ed88b4c
ForNeVeR added a commit that referenced this issue Sep 21, 2021
@ForNeVeR
(#109) XmppTcpConnection: cancellable TCP client connections
3c17dc5
ForNeVeR added a commit that referenced this issue Sep 22, 2021
@ForNeVeR
(#109) XmppTcpConnection: cancellable TCP client connections
cf13551
ForNeVeR added a commit that referenced this issue Sep 22, 2021
@ForNeVeR
(#109) XmppTcpConnection: cancellable TCP client connections
a6d10bb
ForNeVeR added a commit that referenced this issue Sep 23, 2021
@ForNeVeR
(#109) TcpClientEx: add memory leak tests
2d05994
ForNeVeR added a commit that referenced this issue Sep 23, 2021
@ForNeVeR
(#109) XmppTcpConnection: better connection cancellation, better term…
a20980e 
…ination
ForNeVeR added a commit that referenced this issue Sep 23, 2021
@ForNeVeR
(#109) TcpClientExTests: add Linux support
b0d6d7a
ForNeVeR added a commit that referenced this issue Sep 24, 2021
@ForNeVeR
(#109) TcpClientExTests: use same endpoint for host and client
c067278
ForNeVeR added a commit that referenced this issue Sep 24, 2021
@ForNeVeR
(#109) TcpClientExTests: use the same code for all platforms
5df47e9
ForNeVeR added a commit that referenced this issue Sep 24, 2021
@ForNeVeR
(#109) SslStreamEx: additional cancellation check
c8ffe8b
@ForNeVeR ForNeVeR mentioned this issue Sep 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ForNeVeR ForNeVeR

Labels
kind:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Connection cancellation vitalyster/SharpXMPP
1 participant
@ForNeVeR