-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop unmaintained vita-libdl #224
Conversation
isage
commented
Aug 16, 2022
•
edited
Loading
edited
- vita-libdl repo is archived and unmaintained
- it never really worked (Calling require() ON vita-luajit crashes Vita hyln9/vita-libdl#1)
- the only thing using it and why it was added to packages (vita-luajit) is archived too
- Fails to build with latest sdk, which breaks CI for other packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Will you upload your implementation later?
I can if there's demand for it. |
This might cause an issue with the automatic builds for lpp-vita because of this: Rinnegatamante/lpp-vita#56 That shouldn't stop this, though. It's easily reverted. |
So does it work for lpp or not? Rinnegatamante/lpp-vita#41
|
As a quickest and easiest solution, I suggest to use this: https://github.com/v-atamanenko/vita-libdl |
Question is: if it's broken (crashes lpp, i had crashes with it too, since it's installed by default), and no-one intends to fix it - why do we need it? |
lpp-vita doesn't use FFI functionality of vita-luajit, and vita-luajit can be built without FFI support. And to our knowledge there isn't really anything else using either vita-luajit or vita-libdl. Thus, I think we can kill vita-libdl and instead fork only vita-luajit to nuke FFI/vita-libdl usage. I can do that later this week, would require some testing. For the time being, I'd suggest switching to my fork. |
pullrequest it then |
replaced #226 |