Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unmaintained vita-libdl #224

Closed
wants to merge 1 commit into from
Closed

Conversation

isage
Copy link
Contributor

@isage isage commented Aug 16, 2022

Copy link
Contributor

@sharkwouter sharkwouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Will you upload your implementation later?

@isage
Copy link
Contributor Author

isage commented Aug 16, 2022

I can if there's demand for it.

@sharkwouter
Copy link
Contributor

sharkwouter commented Aug 16, 2022

This might cause an issue with the automatic builds for lpp-vita because of this: Rinnegatamante/lpp-vita#56

That shouldn't stop this, though. It's easily reverted.

@isage
Copy link
Contributor Author

isage commented Aug 16, 2022

So does it work for lpp or not? Rinnegatamante/lpp-vita#41
i see few solutions:

  1. drop it
  2. someone should pick it up and maintain, so we switch to it
  3. switch to my impl as long as it works for lpp

@v-atamanenko
Copy link
Contributor

As a quickest and easiest solution, I suggest to use this: https://github.com/v-atamanenko/vita-libdl
It only has the compilation issue fixed, other problems not addressed. In other words, should be enough to preserve the status-quo at least

@isage
Copy link
Contributor Author

isage commented Aug 16, 2022

Question is: if it's broken (crashes lpp, i had crashes with it too, since it's installed by default), and no-one intends to fix it - why do we need it?

@v-atamanenko
Copy link
Contributor

lpp-vita doesn't use FFI functionality of vita-luajit, and vita-luajit can be built without FFI support. And to our knowledge there isn't really anything else using either vita-luajit or vita-libdl. Thus, I think we can kill vita-libdl and instead fork only vita-luajit to nuke FFI/vita-libdl usage. I can do that later this week, would require some testing. For the time being, I'd suggest switching to my fork.

@isage
Copy link
Contributor Author

isage commented Aug 16, 2022

pullrequest it then

@d3m3vilurr
Copy link
Contributor

replaced #226

@d3m3vilurr d3m3vilurr closed this Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants