Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compact examples + cli for examples #167

Merged
merged 6 commits into from
Nov 27, 2021
Merged

Conversation

userquin
Copy link
Member

@userquin userquin commented Nov 24, 2021

This PR compacts the examples to reduce maintenance to a minimum.

The changes made are:

  • removed react-basic and react-basic-inject-manifest examples, removed also scripts from root
  • removed svelte-basic and svelte-basic-inject-manifest examples, removed also scripts from root
  • removed vue-basic and vue-basic-inject-manifest examples, removed also scripts from root
  • added custom service worker (injectManifest) on react-router, svelte-routify and vue-router, added also scripts on root
  • added service worker periodic sw updates for generateSW strategy on react-router, svelte-routify and vue-router
  • updated vue scripts on root, now contains :vue: in the name
  • docs: updated Available Example Projects on examples entry
  • docs: updated vue, react and svelte examples entries

@netlify
Copy link

netlify bot commented Nov 24, 2021

✔️ Deploy Preview for vite-plugin-pwa ready!

🔨 Explore the source changes: cb12a01

🔍 Inspect the deploy log: https://app.netlify.com/sites/vite-plugin-pwa/deploys/619f59ab5293a2000702f8bd

😎 Browse the preview: https://deploy-preview-167--vite-plugin-pwa.netlify.app

@userquin
Copy link
Member Author

userquin commented Nov 24, 2021

Once approved and merged I'll include the cli to run the examples.

EDIT: since the changes are substantial, I'll change this PR to draft to include the cli for examples.

@userquin userquin requested a review from antfu November 24, 2021 12:56
@userquin userquin marked this pull request as draft November 24, 2021 13:30
@userquin userquin marked this pull request as ready for review November 24, 2021 16:30
@userquin userquin changed the title feat: compact examples feat: compact examples + cli for examples Nov 24, 2021
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@userquin userquin mentioned this pull request Nov 26, 2021
@antfu antfu merged commit 609babb into main Nov 27, 2021
@antfu antfu deleted the feat/compact-examples branch November 27, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants