-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sveltekit example #176
Conversation
✔️ Deploy Preview for vite-plugin-pwa ready! 🔨 Explore the source changes: 0b1fbd1 🔍 Inspect the deploy log: https://app.netlify.com/sites/vite-plugin-pwa/deploys/61a6c0f75f89f40007504862 😎 Browse the preview: https://deploy-preview-176--vite-plugin-pwa.netlify.app |
# Conflicts: # docs/.vitepress/config.js
@antfu you should also add |
@antfu I'm talking with Dominik and Ben trying to do a small review on the docs so don't merge yet. |
@benmccann also removed |
I need to update all |
@antfu @benmccann Since we're using here any ideas to make it working? |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@userquin @benmccann I read the docs for sveltekit and am a bit scared. I have been running my own version of a PWA with sveltekit (@userquin knows it) and am interested in leveraging your work here. However, I have two deployment options: vercel and the node-based adapter. I am not yet clear what I need to do to have those working? The docs says it is complex 😄 |
Hi @FunMiles , how long no news from you, take a look at the example in this repo, I think you are using the EDIT: just remove the The |
For vercel deployment, I am using the vercel-adapter. I am also looking at another deployment option and they would need the node-adapter. Hence my question. |
can we go to Discord? |
sure. I am on. |
I don't see you on ViteLand server. |
I wad in svelte-kit one. Opened the ViteLand. |
@userquin How does one cache external assets for offline use? Do I need to pass a rule to cache everything from my CDN's URLs? |
This PR also includes:
autoUpdate
examples for all frameworks usinginjectManifest
strategyexamples cli
to include behaviors forinjectManifest
strategy, also includessveltekit
frameworksveltekit
This PR will be on draft until I update the docs for
sveltekit
.@antfu Once merge you should add
sveltekit
to the project tags.closes #124