Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publish): add packageManager option #26

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 25, 2023

In the recent Vite 5 beta release, npm publish was having trouble publishing vite. We got:

npm ERR! Cannot set properties of null (setting 'peer')

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/patak/.npm/_logs/2023-08-24T16_12_00_148Z-debug-0.log

Running pnpm publish instead fixes it, and I'm not really sure why. It could be pnpm installing dependencies in a certain way that npm fails.

Figured I add a new option instead of hardcoding it so we don't need a major bump, and also npm publish should work fine for our other packages, only vite is hitting this problem strangely.

@bluwy bluwy merged commit 5d363ac into main Aug 25, 2023
1 check passed
@bluwy bluwy deleted the package-manager-publish branch August 25, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants