-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP test: add CI tests for analog #171
Conversation
i checked it locally and seeing this error (was already mentioned on discord earlier)
it looks like somehow yarn doesn't install esbuild correctly? not an expert on that. i suppose we can't convince you to switch to pnpm? 😇 |
i noticed you don't have |
Yep, I can do that. I'll also look into pnpm also 😇 |
Updated the packageManager, still getting the error locally |
are you still using yarn@1 ? I vaguely remember yarn v1 having problems with esbuild, eg evanw/esbuild#1434 i think calling |
@brandonroberts any updates on this? |
Going to pick this back up this week. Did some manual testing with Vite 4 and was able to upgrade without issue. |
75cdac8
to
0e5a31c
Compare
Still investigating build issues (Not Vite related) with migrating. Will reopen when ready |
Adds CI tests for AnalogJS