Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP test: add CI tests for analog #171

Closed
wants to merge 2 commits into from

Conversation

brandonroberts
Copy link

@brandonroberts brandonroberts commented Dec 7, 2022

Adds CI tests for AnalogJS

@brandonroberts brandonroberts changed the title test: add CI tests for analog WIP test: add CI tests for analog Dec 7, 2022
@dominikg
Copy link
Collaborator

dominikg commented Dec 7, 2022

i checked it locally and seeing this error (was already mentioned on discord earlier)

/home/dominikg/develop/vitejs/vite-ecosystem-ci/workspace/analog/analog $> yarn install
yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @vitejs/plugin-legacy@3.0.0-alpha.0" has unmet peer dependency "terser@^5.4.0".
warning " > @vitejs/plugin-legacy@3.0.0-alpha.0" has incorrect peer dependency "vite@^3.0.0".
warning " > @ngtools/webpack@15.0.0" has unmet peer dependency "webpack@^5.54.0".
warning " > @nrwl/vite@15.2.1" has incorrect peer dependency "vite@^3.2.3".
warning "ng-packagr > rollup-plugin-sourcemaps > @rollup/pluginutils@3.1.0" has incorrect peer dependency "rollup@^1.20.0||^2.0.0".
warning "workspace-aggregator-6384da81-6045-43d1-a584-6ebe3f491502 > docs-app > @docusaurus/core > react-loadable-ssr-addon-v5-slorber@1.0.1" has unmet peer dependency "react-loadable@*".
warning "workspace-aggregator-6384da81-6045-43d1-a584-6ebe3f491502 > docs-app > @docusaurus/preset-classic > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/autocomplete-preset-algolia@1.7.1" has unmet peer dependency "@algolia/client-search@^4.9.1".
error An unexpected error occurred: "ENOENT: no such file or directory, stat '/home/dominikg/develop/vitejs/vite-ecosystem-ci/workspace/analog/analog/node_modules/vite/node_modules/esbuild'".
info If you think this is a bug, please open a bug report with the information provided in "/home/dominikg/develop/vitejs/vite-ecosystem-ci/workspace/analog/analog/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
file:///home/dominikg/develop/vitejs/vite-ecosystem-ci/node_modules/.pnpm/execa@6.1.0/node_modules/execa/lib/error.js:59
                error = new Error(message);
                        ^

Error: Command failed with exit code 1: yarn install
warning " > @vitejs/plugin-legacy@3.0.0-alpha.0" has unmet peer dependency "terser@^5.4.0".
warning " > @vitejs/plugin-legacy@3.0.0-alpha.0" has incorrect peer dependency "vite@^3.0.0".
warning " > @ngtools/webpack@15.0.0" has unmet peer dependency "webpack@^5.54.0".
warning " > @nrwl/vite@15.2.1" has incorrect peer dependency "vite@^3.2.3".
warning "ng-packagr > rollup-plugin-sourcemaps > @rollup/pluginutils@3.1.0" has incorrect peer dependency "rollup@^1.20.0||^2.0.0".
warning "workspace-aggregator-6384da81-6045-43d1-a584-6ebe3f491502 > docs-app > @docusaurus/core > react-loadable-ssr-addon-v5-slorber@1.0.1" has unmet peer dependency "react-loadable@*".
warning "workspace-aggregator-6384da81-6045-43d1-a584-6ebe3f491502 > docs-app > @docusaurus/preset-classic > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/autocomplete-preset-algolia@1.7.1" has unmet peer dependency "@algolia/client-search@^4.9.1".
error An unexpected error occurred: "ENOENT: no such file or directory, stat '/home/dominikg/develop/vitejs/vite-ecosystem-ci/workspace/analog/analog/node_modules/vite/node_modules/esbuild'".

it looks like somehow yarn doesn't install esbuild correctly? not an expert on that. i suppose we can't convince you to switch to pnpm? 😇

@dominikg
Copy link
Collaborator

dominikg commented Dec 7, 2022

i noticed you don't have packageManager: "yarn@version" in your root package.json. is it possible for you to add that so that corepack knows which one to use?

@brandonroberts
Copy link
Author

brandonroberts commented Dec 8, 2022

Yep, I can do that. I'll also look into pnpm also 😇

@brandonroberts
Copy link
Author

Updated the packageManager, still getting the error locally

@dominikg
Copy link
Collaborator

dominikg commented Dec 8, 2022

are you still using yarn@1 ?

I vaguely remember yarn v1 having problems with esbuild, eg evanw/esbuild#1434

i think calling yarn set version stable and using v3 would be an improvement over that but would recommend pnpm instead. It's used a lot in the vite, vue and svelte ecosystems and the reception is very positive.

@dominikg
Copy link
Collaborator

@brandonroberts any updates on this?

@brandonroberts
Copy link
Author

Going to pick this back up this week. Did some manual testing with Vite 4 and was able to upgrade without issue.

@brandonroberts
Copy link
Author

Still investigating build issues (Not Vite related) with migrating. Will reopen when ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants