Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditionally get descriptor on hmr #236

Merged
merged 1 commit into from
Aug 22, 2023
Merged

fix: conditionally get descriptor on hmr #236

merged 1 commit into from
Aug 22, 2023

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Aug 22, 2023

Description

Imported the 'fs' module and added a conditional check using fs.existsSync() to ensure that the getDescriptor() function is only called when the file exists. This prevents errors when the file doesn't exist and improves the overall functionality.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Imported the 'fs' module and added a conditional check using `fs.existsSync()` to ensure that the `getDescriptor()` function is only called when the file exists. This prevents errors when the file doesn't exist and improves the overall functionality.
@sxzz sxzz merged commit b7b1383 into main Aug 22, 2023
15 checks passed
@sxzz sxzz deleted the fix/hmr-cache branch August 22, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant