fix(plugin-legacy): legacy sourcemap not generate (fix #11693) (#11841)

vitejs · Jan 31, 2023 · 2ff5930 · 2ff5930
1 parent 5d55083
commit 2ff5930
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/packages/plugin-legacy/src/index.ts b/packages/plugin-legacy/src/index.ts
@@ -578,7 +578,7 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] {
       if (isLegacyBundle(bundle, opts)) {
         // avoid emitting duplicate assets
         for (const name in bundle) {
-          if (bundle[name].type === 'asset') {
+          if (bundle[name].type === 'asset' && !/.+\.map$/.test(name)) {
             delete bundle[name]
           }
         }

diff --git a/playground/legacy/__tests__/legacy.spec.ts b/playground/legacy/__tests__/legacy.spec.ts
@@ -120,4 +120,15 @@ describe.runIf(isBuild)('build', () => {
     expect(findAssetFile(/polyfills-legacy/)).toMatch('"structuredClone"')
     expect(findAssetFile(/polyfills-\w{8}\./)).toMatch('"structuredClone"')
   })
+
+  test('should generate legacy sourcemap file', async () => {
+    expect(
+      listAssets().some((filename) => /index-legacy.+\.map$/.test(filename)),
+    ).toBeTruthy()
+    expect(
+      listAssets().some((filename) =>
+        /polyfills-legacy.+\.map$/.test(filename),
+      ),
+    ).toBeFalsy()
+  })
 })
diff --git a/playground/legacy/vite.config.js b/playground/legacy/vite.config.js
@@ -14,6 +14,7 @@ module.exports = {
   build: {
     cssCodeSplit: false,
     manifest: true,
+    sourcemap: true,
     rollupOptions: {
       input: {
         index: path.resolve(__dirname, 'index.html'),