fix(esbuild): use useDefineForClassFields: false when no `compilerO…

…ptions.target` is declared (#13708)
vitejs · Jul 4, 2023 · 7ef2472 · 7ef2472
1 parent 2b1ffe8
commit 7ef2472
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/packages/vite/src/node/__tests__/plugins/esbuild.spec.ts b/packages/vite/src/node/__tests__/plugins/esbuild.spec.ts
@@ -378,6 +378,11 @@ describe('transformWithEsbuild', () => {
       })
       expect(actual).toBe(defineForClassFieldsTrueTransformedCode)
     })
+
+    test('target: es2022 and tsconfig.target: undefined => false', async () => {
+      const actual = await transformClassCode('es2022', {})
+      expect(actual).toBe(defineForClassFieldsFalseTransformedCode)
+    })
   })
 })
 

diff --git a/packages/vite/src/node/plugins/esbuild.ts b/packages/vite/src/node/plugins/esbuild.ts
@@ -132,6 +132,16 @@ export async function transformWithEsbuild(
       ...tsconfigRaw?.compilerOptions,
     }
 
+    // esbuild uses `useDefineForClassFields: true` when `tsconfig.compilerOptions.target` isn't declared
+    // but we want `useDefineForClassFields: false` when `tsconfig.compilerOptions.target` isn't declared
+    // to align with the TypeScript's behavior
+    if (
+      compilerOptions.useDefineForClassFields === undefined &&
+      compilerOptions.target === undefined
+    ) {
+      compilerOptions.useDefineForClassFields = false
+    }
+
     // esbuild uses tsconfig fields when both the normal options and tsconfig was set
     // but we want to prioritize the normal options
     if (options) {