Skip to content

Commit

Permalink
fix(css): dont remove JS chunk for pure CSS chunk when the export is …
Browse files Browse the repository at this point in the history
…used (#18307)
  • Loading branch information
sapphi-red authored Oct 9, 2024
1 parent b382f7e commit 889bfc0
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion packages/vite/src/node/plugins/css.ts
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ export function cssPostPlugin(config: ResolvedConfig): Plugin {
let chunkCSS = ''
// the chunk is empty if it's a dynamic entry chunk that only contains a CSS import
const isJsChunkEmpty = code === '' && !chunk.isEntry
let isPureCssChunk = true
let isPureCssChunk = chunk.exports.length === 0
const ids = Object.keys(chunk.modules)
for (const id of ids) {
if (styles.has(id)) {
Expand Down
9 changes: 9 additions & 0 deletions playground/glob-import/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,14 @@ export default defineConfig({
},
build: {
sourcemap: true,
rollupOptions: {
output: {
manualChunks(id) {
if (id.includes('foo.css')) {
return 'foo_css'
}
},
},
},
},
})

0 comments on commit 889bfc0

Please sign in to comment.