fix: consider URLs with any protocol to be external (#17369)

Co-authored-by: patak-dev <matias.capeletto@gmail.com> Co-authored-by: bluwy <bjornlu.dev@gmail.com> Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
vitejs · Oct 29, 2024 · a0336bd · a0336bd
1 parent 2c10f9a
commit a0336bd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/vite/src/node/plugins/importAnalysis.ts b/packages/vite/src/node/plugins/importAnalysis.ts
@@ -509,7 +509,10 @@ export function importAnalysisPlugin(config: ResolvedConfig): Plugin {
           // If resolvable, let's resolve it
           if (specifier !== undefined) {
             // skip external / data uri
-            if (isExternalUrl(specifier) || isDataUrl(specifier)) {
+            if (
+              (isExternalUrl(specifier) && !specifier.startsWith('file://')) ||
+              isDataUrl(specifier)
+            ) {
               return
             }
             // skip ssr externals and builtins

diff --git a/packages/vite/src/node/utils.ts b/packages/vite/src/node/utils.ts
@@ -262,7 +262,7 @@ export function isSameFileUri(file1: string, file2: string): boolean {
   )
 }
 
-export const externalRE = /^(https?:)?\/\//
+export const externalRE = /^([a-z]+:)?\/\//
 export const isExternalUrl = (url: string): boolean => externalRE.test(url)
 
 export const dataUrlRE = /^\s*data:/i