fix(manifest): do not fail when using rollupOtions.external (#2532)

vitejs · Mar 16, 2021 · e44cc11 · e44cc11
1 parent fa38f3a
commit e44cc11
Showing 1 changed file with 21 additions and 10 deletions.
diff --git a/packages/vite/src/node/plugins/manifest.ts b/packages/vite/src/node/plugins/manifest.ts
@@ -42,6 +42,20 @@ export function manifestPlugin(config: ResolvedConfig): Plugin {
         }
       }
 
+      function getInternalImports(imports: string[]): string[] {
+        const filteredImports: string[] = []
+
+        for (const file of imports) {
+          if (bundle[file] === undefined) {
+            continue
+          }
+
+          filteredImports.push(getChunkName(bundle[file] as OutputChunk))
+        }
+
+        return filteredImports
+      }
+
       function createChunk(chunk: OutputChunk): ManifestChunk {
         const manifestChunk: ManifestChunk = {
           file: chunk.fileName
@@ -58,20 +72,17 @@ export function manifestPlugin(config: ResolvedConfig): Plugin {
         }
 
         if (chunk.imports.length) {
-          const imports = []
-          for (const file of chunk.imports) {
-            const importItem = bundle[file]
-            importItem && imports.push(getChunkName(importItem as OutputChunk))
-          }
-          if (imports.length > 0) {
-            manifestChunk.imports = imports
+          const internalImports = getInternalImports(chunk.imports)
+          if (internalImports.length > 0) {
+            manifestChunk.imports = internalImports
           }
         }
 
         if (chunk.dynamicImports.length) {
-          manifestChunk.dynamicImports = chunk.dynamicImports.map((file) =>
-            getChunkName(bundle[file] as OutputChunk)
-          )
+          const internalImports = getInternalImports(chunk.dynamicImports)
+          if (internalImports.length > 0) {
+            manifestChunk.dynamicImports = internalImports
+          }
         }
 
         const cssFiles = chunkToEmittedCssFileMap.get(chunk)