fix: handle paths with special characters in injectQuery (fix #2585) (#…

…2614)

packages/vite/src/node/__tests__/utils.spec.ts

@@ -0,0 +1,42 @@
+import { injectQuery } from '../utils'
+
+const isWindows = process.platform === 'win32'
+
+if (isWindows) {
+  // this test will work incorrectly on unix systems
+  test('normalize windows path', () => {
+    expect(injectQuery('C:\\User\\Vite\\Project', 'direct')).toEqual(
+      'C:/User/Vite/Project?direct'
+    )
+  })
+}
+
+test('path with multiple spaces', () => {
+  expect(injectQuery('/usr/vite/path with space', 'direct')).toEqual(
+    '/usr/vite/path with space?direct'
+  )
+})
+
+test('path with multiple % characters', () => {
+  expect(injectQuery('/usr/vite/not%20a%20space', 'direct')).toEqual(
+    '/usr/vite/not%20a%20space?direct'
+  )
+})
+
+test('path with %25', () => {
+  expect(injectQuery('/usr/vite/%25hello%25', 'direct')).toEqual(
+    '/usr/vite/%25hello%25?direct'
+  )
+})
+
+test('path with unicode', () => {
+  expect(injectQuery('/usr/vite/東京', 'direct')).toEqual(
+    '/usr/vite/東京?direct'
+  )
+})
+
+test('path with unicode, space, and %', () => {
+  expect(injectQuery('/usr/vite/東京 %20 hello', 'direct')).toEqual(
+    '/usr/vite/東京 %20 hello?direct'
+  )
+})

packages/vite/src/node/utils.ts

@@ -124,14 +124,17 @@ export function removeImportQuery(url: string) {
 }
 
 export function injectQuery(url: string, queryToInject: string) {
-  let resolvedUrl = new URL(url, 'relative:///')
+  // encode percents for consistent behavior with pathToFileURL
+  // see #2614 for details
+  let resolvedUrl = new URL(url.replace(/%/g, '%25'), 'relative:///')
   if (resolvedUrl.protocol !== 'relative:') {
     resolvedUrl = pathToFileURL(url)
   }
   let { protocol, pathname, search, hash } = resolvedUrl
   if (protocol === 'file:') {
     pathname = pathname.slice(1)
   }
+  pathname = decodeURIComponent(pathname)
   return `${pathname}?${queryToInject}${search ? `&` + search.slice(1) : ''}${
     hash || ''
   }`