ENOENT: no such file or directory, open ...\_metadata.json (Windows only)

[fwouts]

Describe the bug

Since I migrated the Preview.js codebase to the 4.3 beta, the tests have become very flaky, failing pretty much every time on Windows.

The error always looks like:

@previewjs/plugin-svelte:e2e-test: 2:47:14 AM [vite] error while updating dependencies:
@previewjs/plugin-svelte:e2e-test: Error: ENOENT: no such file or directory, open 'D:\a\previewjs\AppData\Local\Temp\svelte-1096\node_modules\.previewjs\v20.0.1\vite\deps_temp_236434d7\_metadata.json'
@previewjs/plugin-svelte:e2e-test:     at Object.openSync (node:fs:601:3)
@previewjs/plugin-svelte:e2e-test:     at Object.writeFileSync (node:fs:2249:35)
@previewjs/plugin-svelte:e2e-test:     at Object.commit (file:///D:/a/previewjs/previewjs/node_modules/.pnpm/vite@4.3.0-beta.4_@types+node@18.15.11/node_modules/vite/dist/node/chunks/dep-a36bfc56.js:44090:18)
@previewjs/plugin-svelte:e2e-test:     at commitProcessing (file:///D:/a/previewjs/previewjs/node_modules/.pnpm/vite@4.3.0-beta.4_@types+node@18.15.11/node_modules/vite/dist/node/chunks/dep-a36bfc56.js:43542:40)
@previewjs/plugin-svelte:e2e-test:     at runOptimizer (file:///D:/a/previewjs/previewjs/node_modules/.pnpm/vite@4.3.0-beta.4_@types+node@18.15.11/node_modules/vite/dist/node/chunks/dep-a36bfc56.js:43580:23)
@previewjs/plugin-svelte:e2e-test:     at onCrawlEnd (file:///D:/a/previewjs/previewjs/node_modules/.pnpm/vite@4.3.0-beta.4_@types+node@18.15.11/node_modules/vite/dist/node/chunks/dep-a36bfc56.js:43765:17)
@previewjs/plugin-svelte:e2e-test:     at processTicksAndRejections (node:internal/process/task_queues:95:5)
@previewjs/plugin-svelte:e2e-test: 2:47:14 AM [vite] error while updating dependencies:
@previewjs/plugin-svelte:e2e-test: TypeError: Cannot read properties of undefined (reading 'browserHash')
@previewjs/plugin-svelte:e2e-test:     at commitProcessing (file:///D:/a/previewjs/previewjs/node_modules/.pnpm/vite@4.3.0-beta.4_@types+node@18.15.11/node_modules/vite/dist/node/chunks/dep-a36bfc56.js:43557:116)
@previewjs/plugin-svelte:e2e-test:     at runOptimizer (file:///D:/a/previewjs/previewjs/node_modules/.pnpm/vite@4.3.0-beta.4_@types+node@18.15.11/node_modules/vite/dist/node/chunks/dep-a36bfc56.js:43580:17)

Example of failed CI runs:

• https://github.com/fwouts/previewjs/actions/runs/4653953320/jobs/8235282905 (4.3.0-beta.4)
• https://github.com/fwouts/previewjs/actions/runs/4674560264/jobs/8278861194 (4.3.0-beta.5)

Reproduction

https://github.com/fwouts/previewjs

Steps to reproduce

I haven't been able to reproduce this on a local Windows machine, and looking at the code it looks like a directory that should exist has perhaps been deleted too early (or not been created?), so I suspect this is a race condition.

System Info

GitHub CI, vite@4.3.0-beta.5, windows-2022, node-18.x

Used Package Manager

pnpm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[sun0day]

I met this error before. Reproduced when vite dev server receives two HTML requests. I will dig into it later

[fwouts]

This isn't happening anymore since upgrading to 4.3.0-beta.7 :)