fix: build time deps optimization, and ensure single crawl end call

[patak-dev]

Description

Fix regression introduced by:

• perf(optimizer): bulk optimizer delay #12609

The awaited promise for registered ids that start a worker bundle process where there is an import for a dependency internally will not be resolved. So when registerWorkersSource is called, we need to stop waiting for it. This worked fine when we awaited one id at a time, but #12609 added a Promise.allSettled that could contain one of these ids. This PRs adds a new Promise indirection so we can resolve these ids promises and let the allSettled finish.

The PR also implements a potential fix for #12836, I think we may not need #12848 after this PR, still needs more testing. And a clean-up of the onCrawlEnd scheme, adding a way to cancel the current crawling.

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[patak-dev]

registeredIds.length === 0 to seenIds.size === 0 is also needed after #12609

[patak-dev]

Started getting a lot of warnings in dev

Error: Failed to load url /classic-shared-worker.js/classic.js (resolved id: /classic-shared-worker.js/classic.js). Does the file exist?
 ❯ loadAndTransform packages/vite/src/node/server/transformRequest.ts:242:22
 ❯ processTicksAndRejections node:internal/process/task_queues:95:5

I don't know if this is the correct fix, seems the PR is exposing this issue?

[bluwy]

Seems to happen on main too. This fix works for me.

[sun0day]

I tested this PR. It fixes #12836 👍

[patak-dev]

Sorry the PR got more complex, but deps optimization during build was broken and we need to fix them in tandem with the changes in this PR. I could separate this into two PRs, but I may need both changes to make every test pass.

If you run pnpm run build in playground/optimized-deps on main, you'll see that there are missing deps messages appearing and that the page will be reloaded (?). This message makes no sense during build because we should never reach it. During build, all non-optimized deps sources needs to be awaited first. So we always have the complete list of dependencies. I don't know for how long we had this issue (it may be that some of the tests added to optimize-deps lately started to show a case that was never handled)

This commit vitejs/vite@c7c9e6c (#12851) fixes the build issue.

[patak-dev]

@sun0day would you retest for #12836 when you have some time?

[patak-dev]

/ecosystem-ci run

[vite-ecosystem-ci]

📝 Ran ecosystem CI: Open

suite	result
astro	✅ success
histoire	❌ failure
iles	❌ failure
ladle	✅ success
laravel	✅ success
marko	✅ success
nuxt	❌ failure
previewjs	✅ success
qwik	✅ success
rakkas	✅ success
sveltekit	✅ success
vite-plugin-ssr	❌ failure
vite-plugin-react	✅ success
vite-plugin-react-pages	✅ success
vite-plugin-react-swc	✅ success
vite-plugin-svelte	✅ success
vite-plugin-vue	✅ success
vite-setup-catalogue	✅ success
vitepress	✅ success
vitest	✅ success
windicss	✅ success

[patak-dev]

Same errors in ecosystem-ci as in main, counts as a good run.

[bluwy]

Code LGTM 👍

[patak-dev]

Let's merge and release to get some testing. @dominikg is thinking that it may be less complex to have ids registered on resolveId without a promise, then clean them up in a post-plugin with a transform hook. We can explore to see if this would work in another PR. I think I tried and it didn't work before but it is worth trying again.

[sun0day]

@sun0day would you retest for #12836 when you have some time?

Works fine! 👍