feat: support base option during dev #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todo: tests I did not check if this works for react, preact, jsx as I am not familiar with those
|
As noted, rebased for 52ae44f |
|
Should this have a deprecation notice or breaking change in the changelog later when released...? |
|
It is backwards compatible and there are deprecation warnings. |
aleclarson
reviewed
Jan 23, 2021
| if (!BASE_URL.startsWith('/') || !BASE_URL.endsWith('/')) { | ||
| logger.warn( | ||
| chalk.bold.yellow( | ||
| `(!) "base" config option should start and end with "/".` |
There was a problem hiding this comment.
This is wrong. The base option can be a https:// URL too.
/cc @yyx990803
6 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the base option as root level config.base. It propagates down to config.build.base to prevent any plugins from breaking that are referencing config.build.base
Issue: #833