Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated config.server.base #13482

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

fi3ework
Copy link
Member

Description

I randomly found server.base (https://vitejs.dev/config/server-options.html#server-base), but it seems like it is not being used anymore. The code was introduced in this pull request (before vite2 was released), but it appears to have not been invoked after a long period of code iteration. The documentation was introduced in this pull request. I suppose the root base config has superseded server.base now.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Jun 10, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never noticed there's this option before. Looks like a good change to me and doesn't seem to break things.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Jun 11, 2023
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the changes of #7289. It seems the PR added server.base to the types and the docs, but the PR didn't use that anywhere.

@patak-dev patak-dev merged commit dc597bd into vitejs:main Jun 12, 2023
brc-dd added a commit to vuejs/vitepress that referenced this pull request Jun 13, 2023
SeniorKyrylo pushed a commit to SeniorKyrylo/VitePress-Vue.js that referenced this pull request Aug 11, 2023
jasonreyes9 added a commit to jasonreyes9/vitepress-vuejs that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants