Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove custom resolveOptions from pre-alias plugin #18041

Conversation

sapphi-red
Copy link
Member

Description

This resolve option was added by #12851. But given that build-time dep-optimization is now removed, we don't need to add this anymore.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Sep 6, 2024
Copy link

stackblitz bot commented Sep 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏼

@patak-dev patak-dev merged commit 6f60adc into vitejs:main Sep 9, 2024
10 of 12 checks passed
@sapphi-red sapphi-red deleted the refactor/remove-custom-resolve-option-from-prealias branch September 10, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants