-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update esbuild target to allow destructuring #2566
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egoist
changed the title
fix: update esbuild target
fix: update esbuild target to allow destructuring
Mar 17, 2021
This seems like a reasonable fix to me because legacy Microsoft Edge versions are no longer supported by Microsoft and are apparently about to be uninstalled in an automatic update. More context: #2564 (comment). |
patak-dev
approved these changes
Mar 17, 2021
patak-dev
added
the
p5-urgent
Fix build-breaking bugs affecting most users, should be released ASAP (priority)
label
Mar 17, 2021
Thanks for the quick fix! |
This was referenced Mar 17, 2021
Closed
Closed
Tanks for quick fix |
This was referenced Mar 18, 2021
Closed
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2564, Fixes #2562, Fixes #2560
Related to changes in esbuild 0.9.3 evanw/esbuild@29b7c3f