Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update esbuild target to allow destructuring #2566

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

egoist
Copy link
Contributor

@egoist egoist commented Mar 17, 2021

Fixes #2564, Fixes #2562, Fixes #2560

Related to changes in esbuild 0.9.3 evanw/esbuild@29b7c3f

@egoist egoist changed the title fix: update esbuild target fix: update esbuild target to allow destructuring Mar 17, 2021
@evanw
Copy link

evanw commented Mar 17, 2021

This seems like a reasonable fix to me because legacy Microsoft Edge versions are no longer supported by Microsoft and are apparently about to be uninstalled in an automatic update. More context: #2564 (comment).

@patak-dev patak-dev added the p5-urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) label Mar 17, 2021
@yyx990803 yyx990803 merged commit da49782 into vitejs:main Mar 17, 2021
@onx2
Copy link

onx2 commented Mar 17, 2021

Thanks for the quick fix!

This was referenced Mar 17, 2021
@suanmei
Copy link

suanmei commented Mar 18, 2021

Tanks for quick fix

This was referenced Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p5-urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority)
Projects
None yet
6 participants