Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove parameters that are not used #10747

Merged
merged 1 commit into from
Nov 12, 2022
Merged

chore: remove parameters that are not used #10747

merged 1 commit into from
Nov 12, 2022

Conversation

chaxus
Copy link
Contributor

@chaxus chaxus commented Nov 1, 2022

Description

Try to remove parameters that are not used

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@chaxus chaxus closed this Nov 1, 2022
@chaxus chaxus reopened this Nov 2, 2022
@benmccann benmccann added the p1-chore Doesn't change code behavior (priority) label Nov 11, 2022
@patak-dev patak-dev merged commit df8e476 into vitejs:main Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaxus @benmccann @patak-dev