-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cherry pick v4 bug fix to v3 #11110
Conversation
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
vite-plugin-ssr is failing on this line during build. And laravel is failing on some node types. Both are type issues and I'm not sure how this PR will cause them to fail though, but perhaps they're already failing with the v3 branch. |
I think this is a safe assumption. @timacdonald @jessarcher @brillout these are important bug fixes that we need to get in the hands of Vite v3 users. I'll hold the release of the next v3 patch for a couple of days in case you see anything here that could affect your projects. |
I believe that the Laravel CI failure is due to the ci repository and not actually a failure withing the Laravel plugin. Just some funky node type mismatching going on. Thanks for the heads up! |
I removed the failing line. I suggest we re-run the CI and see if VPS turns green. I'll then have a look at the type error after the patch release. |
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
Ah, the branch is deleted... ok, here is a manual run for vite-plugin-ssr against v3: |
@brillout looks like it is still broken, let's use the #ecosystem-ci channel in Discord if you would like to keep digging into this. |
I believe this will fix it: vitejs/vite-ecosystem-ci#156. |
/ecosystem-ci run |
cherry pick PRs:
PRs that might be good to cherry pick but didn't for now 🤔
(Might be good to rebase and merge to preserve the individual commits)