Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry pick v4 bug fix to v3 #11110

Merged
merged 5 commits into from
Nov 30, 2022
Merged

chore: cherry pick v4 bug fix to v3 #11110

merged 5 commits into from
Nov 30, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 29, 2022

@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Nov 29, 2022

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ❌ failure
marko ✅ success
nuxt-framework ✅ success
rakkas ✅ success
sveltekit ✅ success
vite-plugin-ssr ❌ failure
vite-plugin-svelte ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@bluwy
Copy link
Member Author

bluwy commented Nov 30, 2022

vite-plugin-ssr is failing on this line during build. And laravel is failing on some node types. Both are type issues and I'm not sure how this PR will cause them to fail though, but perhaps they're already failing with the v3 branch.

@patak-dev
Copy link
Member

vite-plugin-ssr is failing on this line during build. And laravel is failing on some node types. Both are type issues and I'm not sure how this PR will cause them to fail though, but perhaps they're already failing with the v3 branch.

I think this is a safe assumption. @timacdonald @jessarcher @brillout these are important bug fixes that we need to get in the hands of Vite v3 users. I'll hold the release of the next v3 patch for a couple of days in case you see anything here that could affect your projects.

@patak-dev patak-dev merged commit c93a526 into v3 Nov 30, 2022
@patak-dev patak-dev deleted the cherry-pick-v3 branch November 30, 2022 06:00
@timacdonald
Copy link
Contributor

I believe that the Laravel CI failure is due to the ci repository and not actually a failure withing the Laravel plugin. Just some funky node type mismatching going on. Thanks for the heads up!

@brillout
Copy link
Contributor

I removed the failing line. I suggest we re-run the CI and see if VPS turns green. I'll then have a look at the type error after the patch release.

@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Nov 30, 2022

📝 Ran ecosystem CI: Open

suite result
astro ❌ failure
histoire ❌ failure
iles ❌ failure
ladle ❌ failure
laravel ❌ failure
marko ❌ failure
nuxt-framework ❌ failure
rakkas ❌ failure
sveltekit ❌ failure
vite-plugin-ssr ❌ failure
vite-plugin-svelte ❌ failure
vite-setup-catalogue ❌ failure
vitepress ❌ failure
vitest ❌ failure
windicss ❌ failure

@patak-dev
Copy link
Member

Ah, the branch is deleted... ok, here is a manual run for vite-plugin-ssr against v3:
https://github.com/vitejs/vite-ecosystem-ci/actions/runs/3582455847/jobs/6026700491

@patak-dev
Copy link
Member

@brillout looks like it is still broken, let's use the #ecosystem-ci channel in Discord if you would like to keep digging into this.

@brillout
Copy link
Contributor

I believe this will fix it: vitejs/vite-ecosystem-ci#156.

@dominikg
Copy link
Contributor

/ecosystem-ci run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants