Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(env): prevent env expand on process.env #11213

Merged
merged 1 commit into from
Dec 6, 2022
Merged

fix(env): prevent env expand on process.env #11213

merged 1 commit into from
Dec 6, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Dec 6, 2022

Description

Fix #11197

Patches dotenv-expand to not write to process.env by default. Use simpler expand implementation.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Dec 6, 2022
patak-dev
patak-dev approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this one and release it so we still have some days to test it.

@patak-dev patak-dev merged commit d4a1e2b into main Dec 6, 2022
@patak-dev patak-dev deleted the patch-expand-env branch December 6, 2022 19:37
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@bluwy @futurGH
fix(env): prevent env expand on process.env (vitejs#11213)
f215165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Beta] Dotenv expand is failing the build - consider reverting processing process. env
2 participants
@bluwy @patak-dev