Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: after successfully creating a new service, close the previous … #11680

Closed
wants to merge 1 commit into from

Conversation

chenfan0
Copy link
Contributor

@chenfan0 chenfan0 commented Jan 13, 2023

Description

When modifying the vite configuration file, the following situations are likely to occur during the writing process, causing us to have to re-pnpm dev after writing the configuration, which is unfriendly.
image
If we wait until the new serve is successfully created before closing the old serve, then the above situation can be avoided. The following is the effect after modifying the code:
image

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Jan 16, 2023
@chenfan0 chenfan0 deleted the chore/restart branch June 21, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants