Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resolve): update resolve.exports to 2.0.1 to fix * resolution issue #12314

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

bnussman
Copy link
Contributor

@bnussman bnussman commented Mar 6, 2023

Description 📝

  • Fixes Vite unable to resolve wildcard exports on >=4.0.4 #12284 by updating upstream resolve.exports package to 2.0.1
  • Since 4.0.4, Vite has not been able to resolve packages that define exports like the following due to a bug in resolve.exports@2.0.0. The maintainer of resolve.exports has fixed this in 2.0.1
  "exports": {
    ".": {
      "import": "./lib/index.js",
      "require": "./lib/index.cjs"
    },
    "./lib": {
      "import": "./lib/index.js",
      "require": "./lib/index.cjs"
    },
    "./lib/*": {
      "import": "./lib/index.js",
      "require": "./lib/index.cjs"
    }
  },
  • I did not add any tests because tests were added in the upstream package

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Mar 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit 523d6f7 into vitejs:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite unable to resolve wildcard exports on >=4.0.4
2 participants